Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-18097 BRS 46.1 Update cldr & spec versions & status, extend test skip #4195

Merged
merged 1 commit into from
Nov 13, 2024
Merged

CLDR-18097 BRS 46.1 Update cldr & spec versions & status, extend test skip #4195

merged 1 commit into from
Nov 13, 2024

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Nov 12, 2024 •
edited
Loading

CLDR-18097

  • This PR completes the ticket.
  • Update version, status, date in README
  • Update version, status, date in spec (version update here will require bumping version on main branch to accommodate this version, see CLDR-18101)
  • Update version in pom files
  • Update CLDRFile.GEN_VERSION, ToolConstants.DEV_VERSION, ToolConstants.CLDR_VERSIONS, CldrVersion enum
  • Update cldrVersion in dtds (there is a test that requires it be consistent with CLDRFile.GEN_VERSION, ToolCOnstants.DEV_VERSION); this means we need updated dtds for 46.1. But note, did not update the cldrVersion or conformsTo list for ldmlKeyboard3 dtd/xsd since a decimal version does not work for a conformsTo value.
  • Extend currency coverage test skip to include 46.1, add test skip for languages newly failing name coverage test (both coverage issues are already fixed in coverage for CLDR 47).

Note this change is only for the maint/maint-46 branch and not relevant for main.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu self-assigned this Nov 12, 2024
@pedberg-icu pedberg-icu force-pushed the CLDR-18097-BRS461-update-cldr-and-spec-versions-and-status branch from 07ca8c3 to f485aec Compare November 12, 2024 19:56
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

macchiati
macchiati previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (there are still test failures though)

@pedberg-icu pedberg-icu force-pushed the CLDR-18097-BRS461-update-cldr-and-spec-versions-and-status branch from 4df98a1 to 99915c6 Compare November 13, 2024 04:46
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@pedberg-icu
Copy link
Contributor Author

pedberg-icu commented Nov 13, 2024 •
edited
Loading

LGTM (there are still test failures though)

@macchiati Yes, there were some languages newly failing the name coverage test (did not see it in my local tests). Here I just added a test skip, the actual coverage is already updated in CLDR 47. That fixed the test failure here.

@pedberg-icu pedberg-icu merged commit 7f9a5d6 into unicode-org:maint/maint-46 Nov 13, 2024
12 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-18097-BRS461-update-cldr-and-spec-versions-and-status branch November 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

@srl295 srl295 Awaiting requested review from srl295

@AEApple AEApple Awaiting requested review from AEApple

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees

@pedberg-icu pedberg-icu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedberg-icu @macchiati